[Openmp-commits] [PATCH] D99553: [libomptarget] Read standard notes for ELF offload images

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

Right, we don't really have minutes for the weekly call.

I suggested we link the libraries dynamically when clang is linked dynamically and statically when clang is linked statically. Someone pointed out that libomptarget gets distributed with applications that haven't necessarily distributed clang, so unconditionally statically linking makes that use case much easier. That seems right to me, at least as the default cmake thing.

I've emailed openmp-dev. No objections yet. A suggestion for that is to dig out the profiler diff that wanted to unconditionally link an llvm library and reach out to the people who objected then, or to create a diff making the llvm library unconditionally linked in the context of the profiler and see if that attracts objections.

Once the gates are open (i.e. the profiler's required libs are in), depending on llvmobject et al are unlikely to cause further problems. One hopes. It's possible we'll want to link libomptarget itself against the libraries and have the plugins depend on libomptarget for elf munging, just so we don't have N+1 copies of llvm for N plugins. Unless we can statically link (some of) the plugins.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99553/new/

https://reviews.llvm.org/D99553