[Openmp-commits] [PATCH] D77609: [OpenMP] Added the support for unshackled task in RTL

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

In D77609#2345867 <https://reviews.llvm.org/D77609#2345867>, @jdoerfert wrote:

> I left some comments. Generally, I would prefer we minimize the use of the macro to elide declarations. I'd also prefer to use the macro as part of the conditions to avoid duplication.
> Instead of
>
>   #ifdef MACRO
>   foo(X)
>   #else 
>   foo(Y)
>   #endif
>
> we do
>
>   v = MACRO ? X : Y;
>   foo(v);
>
> which is really helpful if `foo` is complex code and just as fast.

Some variables are only defined when the MACRO is enabled. I have changed some code to make it more readable and less complex.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77609/new/

https://reviews.llvm.org/D77609