[Openmp-commits] [PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

[Reid Kleckner via Phabricator via Openmp-commits]

rnk added a comment.

My opinion carries less weight since I don't use CUDA, but I agree with everything Art said. Here's some input, if it helps.

I like the `PATH` search for `ptxas` as a way to make things work out of the box as often as possible.

I don't like the idea of CMake auto-detecting CUDA for the reasons Art listed. It's a great way to implicitly leak more details about the build environment to the user.

An explicit CMake option to override the CUDA installation path seems fine. A distribution could use this if they vend the CUDA SDK somewhere standard, for example.

Lastly, if those things don't work, there is the `CCC_OVERRIDE_OPTIONS` environment variable, so the user always has that escape hatch. A separate environment variable would also be fine. It reminds me of `PYTHON_HOME`, with similar drawbacks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89974/new/

https://reviews.llvm.org/D89974