[Openmp-commits] [PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In D89974#2347979 <https://reviews.llvm.org/D89974#2347979>, @Hahnfeld wrote:

> In D89974#2347938 <https://reviews.llvm.org/D89974#2347938>, @tra wrote:
>
>> I think the default should still let clang search for CUDA or require the user to provide correct CUDA path.  "Use CUDA path discovered by CMake at build time" should be a non-default configuration option if/when it's needed and appropriate.
>
> I agree here. It's definitely surprising to make it the *first* path because `module load`ing another CUDA version and putting it into `PATH` is not recognized anymore.

Also note that `GCC_INSTALL_PREFIX` works differently (empty by default) and must be set explicitly during configure to make the build embed a path into the final executable. Maybe that's the better way to go?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89974/new/

https://reviews.llvm.org/D89974