[Openmp-commits] [PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added a comment.

In D88929#2315513 <https://reviews.llvm.org/D88929#2315513>, @jhuber6 wrote:

> In D88929#2315451 <https://reviews.llvm.org/D88929#2315451>, @ye-luo wrote:
>
>> I just realized that this patch affects clang and libomptarget.
>> I cannot comment on clang. Regarding libomptarget, Could you explain why the detection is not put together with other cuda stuff in `openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake`
>
> If we're sticking with using FindCUDA it's definitely redundant here since it was already called by the time we get here. The support for CUDA language would use the same method but have `enable_language(CUDA)` somewhere instead of `find_package(CUDA)`

Probably not messing with `enable_language(CUDA)` at the moment, just add `cuda_select_nvcc_arch_flags(CUDA_ARCH_FLAGS)` to  `openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88929/new/

https://reviews.llvm.org/D88929