[Openmp-commits] [openmp] 69f8740 - [OpenMP][Archer][Tests] NFC: fix spurious test failure

[Joachim Protze via Openmp-commits]

Author: Joachim Protze
Date: 2020-10-06T00:26:08+02:00
New Revision: 69f87400a85e13482c535365bb19272a15d054b9

URL: https://github.com/llvm/llvm-project/commit/69f87400a85e13482c535365bb19272a15d054b9
DIFF: https://github.com/llvm/llvm-project/commit/69f87400a85e13482c535365bb19272a15d054b9.diff

LOG: [OpenMP][Archer][Tests] NFC: fix spurious test failure

The test disables suppression and therefore sometimes triggers a know false
positive in the openmp runtime. The test should only verify that the env
var is handles as expected.

Added: 
    

Modified: 
    openmp/tools/archer/tests/lit.cfg
    openmp/tools/archer/tests/parallel/parallel-nosuppression.c

Removed: 
    


################################################################################
diff  --git a/openmp/tools/archer/tests/lit.cfg b/openmp/tools/archer/tests/lit.cfg
index f064127817d6..ba810d97c3c4 100644
--- a/openmp/tools/archer/tests/lit.cfg
+++ b/openmp/tools/archer/tests/lit.cfg
@@ -111,7 +111,7 @@ config.substitutions.append(("%clang-archer", config.test_c_compiler))
 config.substitutions.append(("%openmp_flags", config.test_openmp_flags))
 config.substitutions.append(("%archer_flags", config.archer_flags))
 config.substitutions.append(("%flags", config.test_flags))
-config.substitutions.append(("%nosuppression", "env TSAN_OPTIONS='ignore_noninstrumented_modules=0'"))
+config.substitutions.append(("%nosuppression", "env TSAN_OPTIONS='ignore_noninstrumented_modules=0:exitcode=0'"))
 config.substitutions.append(("%suppression", "env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1'"))
 config.substitutions.append(("%deflake", os.path.join(os.path.dirname(__file__), "deflake.bash")))
 

diff  --git a/openmp/tools/archer/tests/parallel/parallel-nosuppression.c b/openmp/tools/archer/tests/parallel/parallel-nosuppression.c
index f0e1cd8b5e46..de46ace01dbb 100644
--- a/openmp/tools/archer/tests/parallel/parallel-nosuppression.c
+++ b/openmp/tools/archer/tests/parallel/parallel-nosuppression.c
@@ -34,7 +34,5 @@ int main(int argc, char *argv[]) {
   return error;
 }
 
-// CHECK-NOT: ThreadSanitizer: data race
-// CHECK-NOT: ThreadSanitizer: reported
 // CHECK: Warning: please export TSAN_OPTIONS
 // CHECK: DONE