[Openmp-commits] [PATCH] D88829: [OpenMP][RTL] Remove dead code

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

Change looks great to me.

Rolling the reduction in leading whitespace in nvptx_target_parallel_reduction_codegen.cpp in with the patch might be contentious, added a couple more reviewers to see if other people would prefer that part split out. I'll accept in a day or so if there are no comments on the whitespace.

Thanks!



================
Comment at: openmp/libomptarget/deviceRTLs/common/src/omptarget.cu:135
         "%d threads\n",
         (int)newTaskDescr->ThreadId(), (int)ThreadLimit);
 }
----------------
This is interesting. This turns out to be the only call to RootS(), and that cascades through a bunch of other code removed in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88829/new/

https://reviews.llvm.org/D88829