[Openmp-commits] [PATCH] D92326: [OpenMP] libomp: fix mutexinoutset dependence for proxy tasks

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/runtime/src/kmp_taskdeps.h:93
+  // Check mutexinoutset dependencies, release locks
+  if (UNLIKELY(node && (node->dn.mtx_num_locks < 0))) {
+    // negative num_locks means all locks were acquired
----------------
AndreyChurbanov wrote:
> tianshilei1992 wrote:
> > Why is it "unlikely"? Because `mutexinoutset` is a rare case?
> > Why is it "unlikely"? Because `mutexinoutset` is a rare case?
> 
> Right.  We still haven't seen real code that uses mutexinoutset dependence.  Even if such code exist there are much more codes those do not use mutexinoutset.  So the performance of this code block looks lesser priority comparing to quicker skip the code when it is not needed.
Gotcha. Thanks for the information.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92326/new/

https://reviews.llvm.org/D92326