[Openmp-commits] [PATCH] D92197: [OpenMP] Avoid internal calls to external compiler interface (kmpc)

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: openmp/runtime/src/kmp.h:3971-3997
+
+template <bool ompt>
+kmp_int32 __kmp_omp_taskwait_template(ident_t *loc_ref, kmp_int32 gtid,
+                                      void *frame_address,
+                                      void *return_address);
+template <bool ompt>
+void __kmp_omp_task_begin_if0_template(ident_t *loc_ref, kmp_int32 gtid,
----------------
I was unsure, where these definitions should go. The functions are called in kmp_gsupport.cpp and kmp_tasking.cpp, the definition is still in kmp_tasking.cpp.


================
Comment at: openmp/runtime/src/kmp_csupport.cpp:476-482
 /*!
 @ingroup PARALLEL
 @param loc  source location information
 @param global_tid  global thread number
 
 Leave a serialized parallel construct.
 */
----------------
Where should the documentation go?


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:1516
         // AC: we are in serialized parallel
-        __kmpc_serialized_parallel(loc, gtid);
+        __kmp_serialized_parallel(loc, gtid);
         KMP_DEBUG_ASSERT(parent_team->t.t_serialized > 1);
----------------
__kmpc_serialized_parallel only asserts valid gtid and stores the OMPT return address before calling __kmp_serialized_parallel. So directly call __kmp_serialized_parallel.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92197/new/

https://reviews.llvm.org/D92197