[Openmp-commits] [PATCH] D91746: [libomptarget] Fail on missing symbols in device image

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

llvm-objcopy is willing to strip the symbols from the device image. Can get the name of exec_mode from llvm-nm. I'm not sure we have tooling for pulling apart the openmp image and reassembling it, or for injecting an external tool to mangle the device image on the way into the binary. Expressing the result in lit/filecheck form means long pipelines and/or several temporary files, but is doable.

I would say the test would be substantially more complicated than the change, and much more likely to be buggy. If we had better testing infra - stuff for making binary files and dicing them - I'd be more in favour.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91746/new/

https://reviews.llvm.org/D91746