[Openmp-commits] [PATCH] D82245: [libomptarget] Add support for target update non-contiguous

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

Would you please take a thorough check with your patch? I can still find many code that still don't conform with the standard. Thanks. The test case is fine as we don't have unified standard.



================
Comment at: openmp/libomptarget/src/omptarget.cpp:768
 // same signature as targetDataBegin and targetDataEnd.
 int target_data_update(DeviceTy &Device, int32_t arg_num,
     void **args_base, void **args, int64_t *arg_sizes, int64_t *arg_types,
----------------
This function does not conform with the standard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82245/new/

https://reviews.llvm.org/D82245