[Openmp-commits] [PATCH] D89898: changing OMP rtl to use shared memory instead of env variable

Roger Ferrer Ibanez via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Nov 18 09:37:03 PST 2020

rogfer01 added a comment.

Hi Todd,

> In D89898#2403115 <https://reviews.llvm.org/D89898#2403115>, @terdner wrote:
> Adding the UID is pretty simple to implement.   Does this solve the problem (because a user can already open a file that is owned by UID) or just make it more rare because now you are only hitting files that you left behind, and not others?

The latter.

I think we can split the issue in two:
a) files that are left behind when a process using OpenMP ends abnormally (think of OpenMP application developers using accidentally causing errors during their development)
b) failing at the startup of an OpenMP process because we attempt to open a file that we didn't create.

Adding the UID would make b) rarer. Solving a) seems much harder to me now, but making b) a seldom event might be enough for now.

Note that I assume that hitting a file we left behind by ourselves is not a problem for the runtime.

Kind regards,

  rG LLVM Github Monorepo



More information about the Openmp-commits mailing list