[Openmp-commits] [PATCH] D91692: [OpenMP][OMPT] Introduce a guard to handle OMPT return address

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Nov 18 02:34:16 PST 2020

protze.joachim created this revision.
protze.joachim added a reviewer: hbae.
protze.joachim added a project: OpenMP.
Herald added subscribers: guansong, yaxunl.
protze.joachim requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

This is an alternative approach to address inconsistencies pointed out in: D90078 <https://reviews.llvm.org/D90078>
This patch makes sure that the return address is reset, when leaving the scope. 
In some cases, I had to move the macro out of an if-statement to have it in the right scope, in some cases I added an additional block to restrict the scope.

This patch does not handle inconsistencies, which might occur if the return address is still set when we call into the application.

In general, I would prefer to pass the address down the stack as function arguments, which is not possible with all the internal calls to external API functions



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91692.306012.patch
Type: text/x-patch
Size: 11119 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20201118/7be4c1dc/attachment-0001.bin>

More information about the Openmp-commits mailing list