[Openmp-commits] [PATCH] D82245: [libomptarget] Add support for target update non-contiguous

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/include/omptarget.h:128
+struct __tgt_target_non_contig {
+  uint64_t offset;
+  uint64_t count;
----------------
Like the `void *Queue` in `__tgt_async_info`


================
Comment at: openmp/libomptarget/src/omptarget.cpp:665
+       ArgSize, DPxPTR(TgtPtrBegin), DPxPTR(HstPtrBegin));
+    int rt = Device.retrieveData(HstPtrBegin, TgtPtrBegin, ArgSize, nullptr);
+    if (rt != OFFLOAD_SUCCESS) {
----------------
Still not LLVM style.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:671
+
+    uintptr_t lb = (uintptr_t)HstPtrBegin;
+    uintptr_t ub = (uintptr_t)HstPtrBegin + ArgSize;
----------------
ditto


================
Comment at: openmp/libomptarget/src/omptarget.cpp:672
+    uintptr_t lb = (uintptr_t)HstPtrBegin;
+    uintptr_t ub = (uintptr_t)HstPtrBegin + ArgSize;
+    Device.ShadowMtx.lock();
----------------
ditto


================
Comment at: openmp/libomptarget/src/omptarget.cpp:674
+    Device.ShadowMtx.lock();
+    for (ShadowPtrListTy::iterator it = Device.ShadowPtrMap.begin();
+         it != Device.ShadowPtrMap.end(); ++it) {
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82245/new/

https://reviews.llvm.org/D82245