[Openmp-commits] [PATCH] D81314: [OpenMP][Tool] Handle detached tasks in Archer

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Nov 11 11:21:36 PST 2020


protze.joachim added inline comments.


================
Comment at: openmp/tools/archer/tests/task/task_late_fulfill.c:37
+    printf("%i: calling omp_fulfill_event\n", omp_get_thread_num());
+    omp_fulfill_event(*f_event);
+//#pragma omp task if (0) depend(in : f_event)
----------------
ye-luo wrote:
> ye-luo wrote:
> > de-referencing uninitialized pointer f_event? I expect no task has been run at this point.
> > de-referencing uninitialized pointer f_event? I expect no task has been run at this point.
> 
> This test is probably good.
> When OMP_NUM_THREADS>1, there are additional threads available for picking up task 1 and task must be completed within 20000 usec. Not robust but probably OK.
> When OMP_NUM_THREADS=1, the parallel is inactive and task 1 runs immediately, task 2 is deferred due to dependency, So this test also works fine.
During discussion for the OpenMP Examples document, I realized that taking the address is not necessary. I pushed a fix as 3fa2e193384048daafe1fa74bf88253b4cf5ce6e.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81314/new/

https://reviews.llvm.org/D81314



More information about the Openmp-commits mailing list