[Openmp-commits] [PATCH] D77609: [OpenMP] Added the support for unshackled task in RTL

Tue Nov 10 10:07:06 PST 2020

tianshilei1992 added a comment.

In D77609#2386352 <https://reviews.llvm.org/D77609#2386352>, @ye-luo wrote:

> In D77609#2386308 <https://reviews.llvm.org/D77609#2386308>, @jdoerfert wrote:
>
>> In D77609#2386307 <https://reviews.llvm.org/D77609#2386307>, @tianshilei1992 wrote:
>>
>>> In D77609#2362867 <https://reviews.llvm.org/D77609#2362867>, @jdoerfert wrote:
>>>
>>>>> Some variables are only defined when the MACRO is enabled. I have changed some code to make it more readable and less complex.
>>>>
>>>> As I said before, I don't see the point in omitting declarations. It just increases our testing surface for no real benefit. If you don't use this but have two more functions and a few declarations, all of which you don't use, you really don't pay a price in the big scheme of things.
>>>>
>>>>> What is a right way to detect whether a CMake variable or macro is defined?
>>>>
>>>> In C/C++ (#ifdef) or in CMake (idk)?
>>>
>>> The point is, our test cases are not run by CMake, so it cannot detect whether we define any variable.
>>
>> Then make USE_UNSHACKLED_TASK default and remove all the uses that elide declarations and definitions.
>
> Better to have a way to elide unshackled thread team creation at runtime before putting LIBOMP_USE_UNSHACKLED_TASK by default.

It's already included in this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77609/new/

https://reviews.llvm.org/D77609