[Openmp-commits] [PATCH] D77609: [OpenMP] Added the support for unshackled task in RTL

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Nov 10 09:36:21 PST 2020

tianshilei1992 added a comment.

In D77609#2362867 <https://reviews.llvm.org/D77609#2362867>, @jdoerfert wrote:

>> Some variables are only defined when the MACRO is enabled. I have changed some code to make it more readable and less complex.
> As I said before, I don't see the point in omitting declarations. It just increases our testing surface for no real benefit. If you don't use this but have two more functions and a few declarations, all of which you don't use, you really don't pay a price in the big scheme of things.
>> What is a right way to detect whether a CMake variable or macro is defined?
> In C/C++ (#ifdef) or in CMake (idk)?

The point is, our test cases are not run by CMake, so it cannot detect whether we define any variable.

  rG LLVM Github Monorepo



More information about the Openmp-commits mailing list