[Openmp-commits] [PATCH] D82245: [libomptarget] Add support for target update non-contiguous

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:638
 
+static int target_data_contiguous(DeviceTy &Device, void *args_base,
+                                  void *HstPtrBegin, int64_t MapSize,
----------------
cchen wrote:
> tianshilei1992 wrote:
> > Since you're modifying this function, could you please change the coding style to LLVM style as well?
> By coding style do you mean the name of the parameters? Can you be more specific? Thanks.
Yes, sort of. You can refer to https://llvm.org/docs/CodingStandards.html for more details.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82245/new/

https://reviews.llvm.org/D82245