[Openmp-commits] [PATCH] D82245: [libomptarget] Add support for target update non-contiguous

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 reopened this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

This patch breaks the building of OpenMP. Please fix it.

  FAILED: libomptarget/src/CMakeFiles/omptarget.dir/omptarget.cpp.o
  /home/shiltian/Documents/deploy/llvm/release/bin/clang++  -DOMPTARGET_DEBUG -Domptarget_EXPORTS -I/home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/include -Wall -Wcast-qual -Wformat-pedantic -Wimplicit-fallthrough -Wsign-compare -Wno-extra -Wno-pedantic -std=gnu++14 -g -fPIC -MD -MT libomptarget/src/CMakeFiles/omptarget.dir/omptarget.cpp.o -MF libomptarget/src/CMakeFiles/omptarget.dir/omptarget.cpp.o.d -o libomptarget/src/CMakeFiles/omptarget.dir/omptarget.cpp.o -c /home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/src/omptarget.cpp
  /home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/src/omptarget.cpp:664:8: error: use of undeclared identifier 'arg_sizes'
         arg_sizes[i], DPxPTR(TgtPtrBegin), DPxPTR(HstPtrBegin));
         ^
  /home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/src/omptarget.cpp:664:18: error: use of undeclared identifier 'i'
         arg_sizes[i], DPxPTR(TgtPtrBegin), DPxPTR(HstPtrBegin));
                   ^
  /home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/src/omptarget.cpp:691:8: error: use of undeclared identifier 'arg_sizes'
         arg_sizes[i], DPxPTR(HstPtrBegin), DPxPTR(TgtPtrBegin));
         ^
  /home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/src/omptarget.cpp:691:18: error: use of undeclared identifier 'i'
         arg_sizes[i], DPxPTR(HstPtrBegin), DPxPTR(TgtPtrBegin));
                   ^
  4 errors generated.

What's more, please follow LLVM coding style.



================
Comment at: openmp/libomptarget/src/omptarget.cpp:664
+    DP("Moving %" PRId64 " bytes (tgt:" DPxMOD ") -> (hst:" DPxMOD ")\n",
+       arg_sizes[i], DPxPTR(TgtPtrBegin), DPxPTR(HstPtrBegin));
+    int rt = Device.retrieveData(HstPtrBegin, TgtPtrBegin, MapSize, nullptr);
----------------
`arg_size` is not defined here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82245/new/

https://reviews.llvm.org/D82245