[Openmp-commits] [PATCH] D90962: [OpenMP] Fix possible NULL dereferences

Fri Nov 6 11:57:46 PST 2020

AndreyChurbanov added a comment.

In D90962#2379674 <https://reviews.llvm.org/D90962#2379674>, @jdoerfert wrote:

> So, we had asserts, right? And this code is "copied" a few times all over. What I try to say is, I'm not sure this is a "fix" and it is sufficient.

KMP_DEBUG_ASSERT is no-op in release build. Thus this patch adds missed checks in order to make static code analyzers happy.
In real codes we haven't encountered broken source location string, but in theory this might happen and then NULL pointer could be dereferenced.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90962/new/

https://reviews.llvm.org/D90962