[Openmp-commits] [PATCH] D81314: [OpenMP][Tool] Handle detached tasks in Archer

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added inline comments.


================
Comment at: openmp/tools/archer/tests/task/task_late_fulfill.c:37
+    printf("%i: calling omp_fulfill_event\n", omp_get_thread_num());
+    omp_fulfill_event(*f_event);
+//#pragma omp task if (0) depend(in : f_event)
----------------
ye-luo wrote:
> de-referencing uninitialized pointer f_event? I expect no task has been run at this point.
> de-referencing uninitialized pointer f_event? I expect no task has been run at this point.

This test is probably good.
When OMP_NUM_THREADS>1, there are additional threads available for picking up task 1 and task must be completed within 20000 usec. Not robust but probably OK.
When OMP_NUM_THREADS=1, the parallel is inactive and task 1 runs immediately, task 2 is deferred due to dependency, So this test also works fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81314/new/

https://reviews.llvm.org/D81314