[Openmp-commits] [PATCH] D90519: [Libomptarget][NFC] Encapsulate Global Libomptarget State

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

Thought I'd commented on this but can't see it. I like the change - one global instance holding all the state is much better than scattering the variables around.

It lends itself to a later change supporting N independent copies of the library, e.g. to facilitate testing.



================
Comment at: openmp/libomptarget/src/rtl.cpp:34
 
-RTLsTy *RTLs;
-std::mutex *RTLsMtx;
-
-HostEntriesBeginToTransTableTy *HostEntriesBeginToTransTable;
-std::mutex *TrlTblMtx;
-
-HostPtrToTableMapTy *HostPtrToTableMap;
-std::mutex *TblMapMtx;
+PluginManager *PM;
 
----------------
I might have g


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90519/new/

https://reviews.llvm.org/D90519