[Openmp-commits] [PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

Anchu Rajendran S via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jun 30 21:07:26 PDT 2020


anchu-rajendran accepted this revision.
anchu-rajendran added a comment.
This revision is now accepted and ready to land.

LGTM :). Thanks!



================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1543
+        OMPBuilder->getOrCreateIdent(SrcLocStr));
+  }
 
----------------
Nit: I think its better to add comments on the implicit assumptions in clang code / on why initializations here is not required if OMPIRBuilder is not used. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82822/new/

https://reviews.llvm.org/D82822





More information about the Openmp-commits mailing list