[Openmp-commits] [PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

Sourabh Singh Tomar via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jun 26 04:18:44 PDT 2020


SouraVX added a comment.

Overall this seems great Thanks! I have one minor concern:
This patch seems to do 2 things: Support for nested parallel regions(which was crashing earlier) and some infrastructure change(introducing AllocBuilder..).
I'm not sure of this, but is it possible to separate these as 2( or more) patches ? 1 for Nested parallel region support and other patch as a infrastructure change ?

Main benefit of this approach would be that this would be easier to track/maintain changes in future.
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82470/new/

https://reviews.llvm.org/D82470





More information about the Openmp-commits mailing list