[Openmp-commits] [PATCH] D81054: [OpenMP] Introduce target memory manager

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

In D81054#2102130 <https://reviews.llvm.org/D81054#2102130>, @ye-luo wrote:

> I think this optimization can be an option but not replacing the existing scheme directly allocate/free memory.
>  Application may request device memory outside openmp and use vendor native programming model or libraries.
>  Having libomptarget holding large memory doesn't make sense.
>  You may consider using the pool only for very small allocation requests <1M.
>  It is application's responsibility to take care of large memory allocation.


I agree with you that this optimization could be optional, enabled/disabled by an environment variable maybe, such that power users can still take care of everything on their own, but I don’t think every user is power user, and would use OpenMP offloading in an expert’s way that allocating memory using device RTL functions and then use them directly. They might still use interfaces provided by OpenMP to allocate device memory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81054/new/

https://reviews.llvm.org/D81054