[Openmp-commits] [PATCH] D82074: [OpenMP] Set cmake policy CMP0075 to NEW

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added a comment.

In D82074#2101026 <https://reviews.llvm.org/D82074#2101026>, @protze.joachim wrote:

> OpenMP can be built stand-alone. Some HPC centers have quite old OS on their systems, therefore we only bumped cmake requirement if really necessary.


"We only bumped cmake requirement if really necessary." I agree to this to some extend.
"Some HPC centers have quite old OS on their systems, therefore we only bumped cmake requirement if really necessary." I don't agree with this.
HPC centers got constant requests for new cmake from cmake users and they always provide quite new cmake (within 2 years). They never relies on system cmake.
If there is only the old system cmake, building cmake is fairly easy. If sb are not able to build cmake, they probably don't have the need of building libomp standalone.

Comes to the need. CMake had many rounds of change for handling CUDA since 2.8 and I don't believe current 2.8 is still valid.
I also think re-trigger cmake when make is caused by some legacy way of *.cu handling in CMake.

LLVM cmake requirement is very conservative. Most people builds openmp with llvm and the cmake version is getting validated.
It is bad someone comes and say openmp cannot be built and we find it was caused by an old cmake between 2.8 and LLVM required version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82074/new/

https://reviews.llvm.org/D82074