[Openmp-commits] [PATCH] D76012: [OpenMP][Tool] Header-only multiplexing of OMPT tools

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Jun 10 09:17:51 PDT 2020


jdoerfert added a comment.

In D76012#2083276 <https://reviews.llvm.org/D76012#2083276>, @protze.joachim wrote:

> As an alternative, I could make the tools header files, which are conditionally included:
>
>   #ifdef FIRST
>   #include <first_tool.h>
>   #elif SECOND
>   #include <second_tool.h>
>   #else
>   ... current app content
>   #endif
>
>
> Then we have only one C file, which has the app code and the test expressions. The tool libraries are compiled from the header files.


Assuming I understand this properly, this makes sense. Some places we also have `test/Inputs/` folders for "include headers" but if they can live right in the `print` folder, fine with me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76012/new/

https://reviews.llvm.org/D76012





More information about the Openmp-commits mailing list