[Openmp-commits] [PATCH] D76008: [OpenMP][Tool] Extend reuse of OMPT testing

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Jun 10 08:44:12 PDT 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, one comment below.



================
Comment at: openmp/runtime/test/ompt/callback.h:21
+#define OMPT_TESTS
+#endif
+
----------------
I think you should use the compiler namespace here `_TOOLS_PREFIX` and `_OMPT_TESTS`. Also undef them at the end :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76008/new/

https://reviews.llvm.org/D76008





More information about the Openmp-commits mailing list