[Openmp-commits] [PATCH] D76012: [OpenMP][Tool] Header-only multiplexing of OMPT tools

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

Ok, this is not how suffix works in lit :(
lit splits file suffix using `base,ext = os.path.splitext(filename)`. This will always be `.c` for C files. We could play tricks with non-standard file suffixes for the libraries built and used for the test. The extension is then compared to the list provided in `config.suffixes`.

Just for reference, if I remove the RUN line, the output of make check-ompt-multiplex will contain this:

  UNRESOLVED: OMPT multiplex :: custom_data_storage/custom_data_storage.app.c.second.tool.c (1 of 6)
  ******************** TEST 'OMPT multiplex :: custom_data_storage/custom_data_storage.app.c.second.tool.c' FAILED ********************
  Test has no run line!
  ********************

I could change the lines to:

  // RUN: do-not-run
  // REQUIRES: do-not-run

But then we always have 2 successful, 4 unsupported tests listed instead of 6 successful tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76012/new/

https://reviews.llvm.org/D76012