[Openmp-commits] [PATCH] D76008: [OpenMP][Tool] Extend reuse of OMPT testing

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jun 5 08:54:52 PDT 2020


jdoerfert added a comment.

Is there a reasonable way to test this?



================
Comment at: openmp/runtime/test/ompt/callback.h:1031
+
+#ifndef NO_TOOL
+  // print task data
----------------
Style: If this is the only use case, shouldn't we avoid double negation here and define something like `TOOL_PRESENT` in case the prefix is defined?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76008/new/

https://reviews.llvm.org/D76008





More information about the Openmp-commits mailing list