[Openmp-commits] [PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

In D80735#2071897 <https://reviews.llvm.org/D80735#2071897>, @jhuber6 wrote:

> I'm just investigating migrating D80222 <https://reviews.llvm.org/D80222> away from the static methods. When I try to just add an OpenMPIRBuilder type and initialize it I get failures on the tests. I'm just adding in the module as you have 
>  `CGOpenMPRuntime.h`
>
>   llvm::OpenMPIRBuilder InternalOMPBuilder;
>   
>
> `CGOpenMPRuntime.cpp`
>
>   CGOpenMPRuntime::CGOpenMPRuntime(CodeGenModule &CGM, StringRef FirstSeparator,
>                                    StringRef Separator)
>       : CGM(CGM), FirstSeparator(FirstSeparator), Separator(Separator),
>         InternalOMPBuilder(CGM.getModule()), OffloadEntriesInfoManager(CGM) {
>     InternalOMPBuilder.initialize();
>
>
> But it causes most of the tests to fail even without using the IRBuilder object.


That is interesting but hard to diagnose. Btw. if you use the OMPIRBuilder it could be that the missing insertion point is the problem, see the changes I made to IRBuilder(Base). If not, we need to look at the test failures more closely.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80735/new/

https://reviews.llvm.org/D80735