[Openmp-commits] [PATCH] D81054: [OpenMP] Introduce target memory manager

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/memory.cpp:111
+        // Cannot free memory on device
+        // TODO: Maybe should raise an expcetion?
+        if (Ret != OFFLOAD_SUCCESS)
----------------
JonChesterfield wrote:
> LLVM is built with exceptions disabled, so probably shouldn't raise here
This is the runtime, so exceptions "would work". However, no exceptions please. There is no defined interface and no reason to believe the user has a C++ exception handler waiting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81054/new/

https://reviews.llvm.org/D81054