[Openmp-commits] [PATCH] D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP support

Thu Jul 23 08:51:08 PDT 2020

hfinkel added a comment.

Thanks for working on this. Please, however, take another pass of the test cases (especially those that are not in the PowerPC directory).  Many of those should not be deleted, please change triple instead. They're testing general functionality.

================
Comment at: llvm/test/Transforms/DeadStoreElimination/combined-partial-overwrites.ll:1
-; RUN: opt -S -dse -enable-dse-partial-store-merging=false < %s | FileCheck %s
-target datalayout = "E-m:e-i64:64-n32:64"
----------------
This test should not be deleted. Change the triple.

================
Comment at: llvm/test/Transforms/EntryExitInstrumenter/mcount.ll:1
-; RUN: opt -passes="function(ee-instrument),cgscc(inline),function(post-inline-ee-instrument)" -S < %s | FileCheck %s
-
----------------
This test should not be deleted. It's testing general functionality. The triple should be changed.

================
Comment at: openmp/runtime/src/kmp_platform.h:71
-#undef KMP_OS_CNK
-#define KMP_OS_CNK 1
-#endif
----------------
Was this not used anywhere? Or is there more to delete?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83915/new/

https://reviews.llvm.org/D83915