[Openmp-commits] [PATCH] D84996: [OpenMP] Fixed the issue that target memory deallocation might be called when they're being used

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

[Drive By]



================
Comment at: openmp/libomptarget/src/omptarget.cpp:434
+      : HstPtrBegin(P), DataSize(S), ForceDelete(F), HasCloseModifier(H) {}
+};
+} // namespace
----------------
Please use proper names even for argument. Also add doxygen comments to all members.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84996/new/

https://reviews.llvm.org/D84996