[Openmp-commits] [PATCH] D84778: [OpenMP] Refactor the `target` function

Tue Jul 28 12:57:33 PDT 2020

ye-luo added a comment.

In D84778#2179627 <https://reviews.llvm.org/D84778#2179627>, @tianshilei1992 wrote:

> I don't think it deserves three patches. The goal is to refactor the `target` function, and this patch just did this only thing. According to the bi-weekly meeting, the renaming could be with other related changes.
>
> In D84778#2179502 <https://reviews.llvm.org/D84778#2179502>, @ye-luo wrote:
>
>> In addtion, should we update target_data_update as well?
>
> I didn't touch `target_data_update`. Basically I only take care of related code.

I think if massive renaming files and variables significantly introduce challenges for code review on the relevant change. It is more appropriate to do the renaming separately.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84778/new/

https://reviews.llvm.org/D84778