[Openmp-commits] [openmp] 9b4826d - [OpenMP] Fix libomptarget negative tests to expect abort

Joel E. Denny via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 28 06:02:32 PDT 2020


Author: Joel E. Denny
Date: 2020-07-28T09:02:16-04:00
New Revision: 9b4826d18b5fba5fe638e1045c9c47d3fe8da8c8

URL: https://github.com/llvm/llvm-project/commit/9b4826d18b5fba5fe638e1045c9c47d3fe8da8c8
DIFF: https://github.com/llvm/llvm-project/commit/9b4826d18b5fba5fe638e1045c9c47d3fe8da8c8.diff

LOG: [OpenMP] Fix libomptarget negative tests to expect abort

On runtime failures, D83963 causes the runtime to abort instead of
merely exiting with a non-zero value, but many tests in the
libomptarget test suite still expect the former behavior.  This patch
updates the test suite and was discussed in post-commit comments on
D83963 and D84557.

Added: 
    

Modified: 
    openmp/libomptarget/test/lit.cfg

Removed: 
    


################################################################################
diff  --git a/openmp/libomptarget/test/lit.cfg b/openmp/libomptarget/test/lit.cfg
index 77476c6fec79..6936bfa0c319 100644
--- a/openmp/libomptarget/test/lit.cfg
+++ b/openmp/libomptarget/test/lit.cfg
@@ -114,7 +114,7 @@ for libomptarget_target in config.libomptarget_all_targets:
             "%t-" + libomptarget_target))
         config.substitutions.append(("%libomptarget-run-fail-" + \
             libomptarget_target, \
-            "%not %t-" + libomptarget_target))
+            "%not --crash %t-" + libomptarget_target))
         config.substitutions.append(("%clangxx-" + libomptarget_target, \
             "%clangxx %openmp_flags %flags -fopenmp-targets=" + libomptarget_target))
         config.substitutions.append(("%clang-" + libomptarget_target, \


        


More information about the Openmp-commits mailing list