[Openmp-commits] [PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny added a comment.

In D84422#2170702 <https://reviews.llvm.org/D84422#2170702>, @RaviNarayanaswamy wrote:

> In D84422#2170667 <https://reviews.llvm.org/D84422#2170667>, @grokos wrote:
>
> > So is the test case that motivated this patch illegal OpenMP code?
> >
> >   #pragma omp target enter data map(alloc:i)
> >   #pragma omp target data map(present, alloc: i)
> >   {
> >     #pragma omp target exit data map(delete:i) // you cannot delete that object in the scope, illegal code?
> >   } // fails presence check here
>
>
> According to spec the test should work.  ie should not check for presence on exit from a blocked openmp pragma scope.


It sounds like this patch's motivation is correct then.  Has anyone clarified the motivation for this behavior?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84422/new/

https://reviews.llvm.org/D84422