[Openmp-commits] [PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

[Ravi Narayanaswamy via Phabricator via Openmp-commits]

RaviNarayanaswamy added a comment.

In D84422#2170285 <https://reviews.llvm.org/D84422#2170285>, @grokos wrote:

> What confuses me about this interpretation of the standard is the inconsistency at `data exit`. So if we have an explicit `omp target exit data map(present...)` then we should respect the "present" semantics, whereas when we have a scoped data exit:
>
>   #pragma omp target data map(present,...)
>   {
>     ...
>   } // implicit "exit data" here
>
>
> then "present" should be ignored.
>
> I agree that the paragraph from the standard leaves little room for other interpretations, I'd just like to point out that it looks inconsistent - at least to me.


When you  use present on a  variable on a scoped target data region,  you  cannot delete that object in the scope.  I would say this  is a test case error.  It should still be present on exit, checking for that is maybe redundant


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84422/new/

https://reviews.llvm.org/D84422