[Openmp-commits] [PATCH] D84456: Refactor OpenMP memory allocation code for easier support for third party memory libraries

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jul 23 12:46:33 PDT 2020


jdoerfert added a comment.

Assuming I read this right, it should be split into two patches. First, move the memkind logic into the thirdparty folder. Second, introduce the SICM support. WDYT?



================
Comment at: openmp/runtime/src/kmp_runtime.cpp:531
+  __kmp_init_memkind();
+  __kmp_init_sicm();
+}
----------------
We should use `LIBOMP_USE_SICM` to avoid calling any "sicm" related functions. This avoids the need for mock functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84456/new/

https://reviews.llvm.org/D84456





More information about the Openmp-commits mailing list