[Openmp-commits] [PATCH] D84148: [openmp] Fix libomp.so copy in multi-config generators.

David Truby via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Jul 20 04:20:30 PDT 2020


DavidTruby added a comment.

I'm a little uncomfortable with this line copying things from the build directory to the source directory; I believe the source directory should be able to be immutable and builds should still work. Part of the principle of having out-of-tree builds is that the source tree should remain unmodified.
Regardless, I haven't changed the behaviour here as I don't know why the library gets copied to the source directory. Perhaps someone could clarify that? Until then I am just replicating the existing behaviour but with it also working for multi-config generators.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84148/new/

https://reviews.llvm.org/D84148





More information about the Openmp-commits mailing list