[Openmp-commits] [PATCH] D84062: [OpenMP] libomp cleanup: add check of input global tid parameter

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM for the gtid changes. there are at least three other things in this commit that need to be split. I don't think they are bad but not described or related to this.



================
Comment at: openmp/runtime/src/kmp_itt.inl:235
+        return; // something's gone wrong, returning
+      if (__kmp_itt_region_team_size[frm] != team_size) {
         char *buff = NULL;
----------------
This seems unrelated.


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:4961
+    // check we won't access uninitialized hot_teams, just in case
+    KMP_DEBUG_ASSERT(new_nproc == 1);
   }
----------------
I guess this is unrelated too.


================
Comment at: openmp/runtime/src/kmp_sched.cpp:68
+    loc = &loc_stub; // may need to report location info to ittnotify
+}
+
----------------
This belongs in a different commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84062/new/

https://reviews.llvm.org/D84062