[Openmp-commits] [PATCH] D83832: [OpenMP] Provide a flag to disable safety checks for GPU optimizations

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

I think there's an unfortunate interaction with link time optimisation here. If there are external regions, but their code is combined with llvm-link before codegen, then a user could reasonably assume this flag is safe.

Would it would be correct to compile the individual source assuming there may be external uses, then llvm-link the source, then run the pass assuming there are no external uses? That's of interest to the amdgcn case as we can (currently) assume the whole program is available towards the end of the compilation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83832/new/

https://reviews.llvm.org/D83832