[Openmp-commits] [PATCH] D83804: [OpenMP] libomp: added itt notifications for task, taskwait, taskgroup.

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov created this revision.
AndreyChurbanov added reviewers: hbae, tlwilmar.
AndreyChurbanov added a project: OpenMP.
Herald added subscribers: openmp-commits, sstefan1, guansong, yaxunl.
Herald added a reviewer: jdoerfert.

Without this patch Intel Inspector reports race conditions on fibonacci test, like in code block:
#pragma omp task

  i = fib(n-2);

#pragma omp task

  j = fib(n-1);

#pragma omp taskwait

  return i + j; // <-- false write-read race with i=..., j=...

The patch adds synchronization notifications between task/taskwait, and task/end taskgroup.
Also added suppression on manually synchronized variables in debug mode. This allows to analyze library internals with lesser false positives.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83804

Files:
  openmp/runtime/src/kmp_runtime.cpp
  openmp/runtime/src/kmp_tasking.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83804.277928.patch
Type: text/x-patch
Size: 6044 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20200714/f72bf0aa/attachment.bin>