[Openmp-commits] [PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

Fri Jul 10 16:47:40 PDT 2020

tra added a comment.

In D83591#2145378 <https://reviews.llvm.org/D83591#2145378>, @JonChesterfield wrote:

> Fine by me. Let's get nvptx working properly in tree now and work out how to wire up amdgcn subsequently. I'm sure a reasonable abstraction will present itself.

I'm missing something -- what was wrong with the changes in D80897 <https://reviews.llvm.org/D80897> ?
AMD's HIP compilation already piggy-backs on using clang's C++ wrappers, so this change will likely break them now and I'll be the first in line to revert the change.

@yaxunl -- Sam, does this change affect HIP compilation? If it does, perhaps we should keep C++-based macro definitions around.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83591/new/

https://reviews.llvm.org/D83591