[Openmp-commits] [PATCH] D83269: [OpenMP] Identify GPU kernels (aka. OpenMP target regions)

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1139
 #define OMP_RTL(_Enum, _Name, ...)                                             \
-  if (M.getFunction(_Name))                                                    \
-    return OMPInModule = true;
+  else if (M.getFunction(_Name)) OMPInModule = true;
 #include "llvm/Frontend/OpenMP/OMPKinds.def"
----------------
tianshilei1992 wrote:
> This line of change looks not related to this patch.
It is. I needed to get rid of the return statements and I wanted to keep the "early exit" out of the if-cascade. Entrance: `else`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83269/new/

https://reviews.llvm.org/D83269