[Openmp-commits] [PATCH] D68100: [OpenMP 5.0] declare mapper runtime implementation

[George Rokos via Phabricator via Openmp-commits]

grokos updated this revision to Diff 275793.
grokos added a comment.

I tried to address our previous complaints about code duplication and came up with a scheme which results in a much shorter and cleaner diff with virtually no code duplication. Instead of refactoring code from `taget_data_begin/end/update`, I introduced a new internal function `target_data_mapper` which generates new arrays `args_base`, `args`, `arg_sizes` and `arg_types` for the custom mapper and calls `target_data_begin/end/update` again using the new arguments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68100/new/

https://reviews.llvm.org/D68100

Files:
  openmp/libomptarget/include/omptarget.h
  openmp/libomptarget/src/exports
  openmp/libomptarget/src/interface.cpp
  openmp/libomptarget/src/omptarget.cpp
  openmp/libomptarget/src/private.h
  openmp/libomptarget/src/rtl.cpp
  openmp/libomptarget/test/mapping/declare_mapper_api.cpp
  openmp/libomptarget/test/mapping/declare_mapper_target.cpp
  openmp/libomptarget/test/mapping/declare_mapper_target_data.cpp
  openmp/libomptarget/test/mapping/declare_mapper_target_data_enter_exit.cpp
  openmp/libomptarget/test/mapping/declare_mapper_target_update.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68100.275793.patch
Type: text/x-patch
Size: 34911 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20200706/6d643d0f/attachment-0001.bin>