[Openmp-commits] [openmp] 8289f28 - [OpenMP][Tests] Flag compatibility of OpenMP runtime tests with GCC versions

[Joachim Protze via Openmp-commits]

Author: Joachim Protze
Date: 2020-07-05T22:49:54+02:00
New Revision: 8289f2891e8691987b9ef9da248011798796ef45

URL: https://github.com/llvm/llvm-project/commit/8289f2891e8691987b9ef9da248011798796ef45
DIFF: https://github.com/llvm/llvm-project/commit/8289f2891e8691987b9ef9da248011798796ef45.diff

LOG: [OpenMP][Tests] Flag compatibility of OpenMP runtime tests with GCC versions

If the compilation fails, the test is marked as unsupported.
-> This will never change for a specific version of gcc

If the linking fails, the test is marked as expected to fail.
-> This might change as LLVM/OpenMP implements the missing GOMP interface function

Reviewed by: Hahnfeld

Differential Revision: https://reviews.llvm.org/D83077

Added: 
    

Modified: 
    openmp/runtime/test/tasking/omp_detach_taskwait.c
    openmp/runtime/test/tasking/omp_task_red_taskloop.c
    openmp/runtime/test/worksharing/for/bug_set_schedule_0.c
    openmp/runtime/test/worksharing/for/omp_for_schedule_runtime.c
    openmp/runtime/test/worksharing/for/omp_nonmonotonic_dynamic1.c

Removed: 
    


################################################################################
diff  --git a/openmp/runtime/test/tasking/omp_detach_taskwait.c b/openmp/runtime/test/tasking/omp_detach_taskwait.c
index 66c9b8364144..c45de2b98c28 100644
--- a/openmp/runtime/test/tasking/omp_detach_taskwait.c
+++ b/openmp/runtime/test/tasking/omp_detach_taskwait.c
@@ -1,8 +1,8 @@
 // RUN: %libomp-compile -fopenmp-version=50 && env OMP_NUM_THREADS='3' %libomp-run
 // RUN: %libomp-compile -fopenmp-version=50 && env OMP_NUM_THREADS='1' %libomp-run
 
-// Checked gcc 9.2 still does not support detach clause on task construct.
-// UNSUPPORTED: gcc-4, gcc-5, gcc-6, gcc-7, gcc-8, gcc-9
+// Checked gcc 10.1 still does not support detach clause on task construct.
+// UNSUPPORTED: gcc-4, gcc-5, gcc-6, gcc-7, gcc-8, gcc-9, gcc-10
 // clang supports detach clause since version 11.
 // UNSUPPORTED: clang-10, clang-9, clang-8, clang-7
 // icc compiler does not support detach clause.

diff  --git a/openmp/runtime/test/tasking/omp_task_red_taskloop.c b/openmp/runtime/test/tasking/omp_task_red_taskloop.c
index bcc4b84ef8ce..35987f6bc053 100644
--- a/openmp/runtime/test/tasking/omp_task_red_taskloop.c
+++ b/openmp/runtime/test/tasking/omp_task_red_taskloop.c
@@ -1,5 +1,12 @@
 // RUN: %libomp-compile-and-run
 
+// Parsing error until gcc8:
+// UNSUPPORTED: gcc-4, gcc-5, gcc-6, gcc-7, gcc-8
+
+// Missing GOMP_taskgroup_reduction_(un)register in LLVM/OpenMP
+// Should be removed once the functions are implemented
+// XFAIL: gcc-9, gcc-10
+
 #include <stdio.h>
 #include <omp.h>
 

diff  --git a/openmp/runtime/test/worksharing/for/bug_set_schedule_0.c b/openmp/runtime/test/worksharing/for/bug_set_schedule_0.c
index 889e2393e2c6..97ba492da3d2 100644
--- a/openmp/runtime/test/worksharing/for/bug_set_schedule_0.c
+++ b/openmp/runtime/test/worksharing/for/bug_set_schedule_0.c
@@ -1,4 +1,9 @@
 // RUN: %libomp-compile-and-run
+
+// gcc 9/10 use GOMP_parallel_loop_maybe_nonmonotonic_runtime, not implemented
+// Should be removed once the functions are implemented
+// XFAIL: gcc-9, gcc-10
+
 #include <stdio.h>
 #include <omp.h>
 #include "omp_testsuite.h"

diff  --git a/openmp/runtime/test/worksharing/for/omp_for_schedule_runtime.c b/openmp/runtime/test/worksharing/for/omp_for_schedule_runtime.c
index b957fc38fffa..0b8cd8900f08 100644
--- a/openmp/runtime/test/worksharing/for/omp_for_schedule_runtime.c
+++ b/openmp/runtime/test/worksharing/for/omp_for_schedule_runtime.c
@@ -10,6 +10,11 @@
 // RUN: env OMP_SCHEDULE=trapezoidal,13 %libomp-run 101 13
 // RUN: env OMP_SCHEDULE=static_steal %libomp-run 102 1
 // RUN: env OMP_SCHEDULE=static_steal,14 %libomp-run 102 14
+
+// gcc 9/10 use GOMP_parallel_loop_maybe_nonmonotonic_runtime, not implemented
+// Should be removed once the functions are implemented
+// XFAIL: gcc-9, gcc-10
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <math.h>

diff  --git a/openmp/runtime/test/worksharing/for/omp_nonmonotonic_dynamic1.c b/openmp/runtime/test/worksharing/for/omp_nonmonotonic_dynamic1.c
index 0691353fe59e..47341484283f 100644
--- a/openmp/runtime/test/worksharing/for/omp_nonmonotonic_dynamic1.c
+++ b/openmp/runtime/test/worksharing/for/omp_nonmonotonic_dynamic1.c
@@ -1,6 +1,10 @@
 // RUN: %libomp-compile
 // RUN: env OMP_SCHEDULE=nonmonotonic:dynamic,10 %libomp-run
 
+// gcc 9/10 use GOMP_parallel_loop_maybe_nonmonotonic_runtime, not implemented
+// Should be removed once the functions are implemented
+// XFAIL: gcc-9, gcc-10
+
 // The test checks iterations distribution for OMP 5.0 nonmonotonic OMP_SCHEDULE
 // case #threads > #chunks (fallback to monotonic dynamic)