[Openmp-commits] [PATCH] D82267: [OpenMP][Tests] Fix/Mark compatibilty for GCC

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sun Jul 5 11:43:37 PDT 2020


Hahnfeld added a comment.

The summary also talks about `tools/multiplex/tests/*`, is that information obsolete?



================
Comment at: openmp/runtime/test/ompt/tasks/dependences_mtxinoutset.c:3-6
+// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8
+
+// GCC does not pass in mutexinoutset
+// clang 9 introduced codegen for mutexinoutset
----------------
I would put the comment in front of the `UNSUPPORTED` and possibly split into `gcc` and `clang-4, ...`. Also can we rename the test file to the full `mutexinoutset`? That's two additional characters, but easier to search for.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82267/new/

https://reviews.llvm.org/D82267





More information about the Openmp-commits mailing list