[Openmp-commits] [PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

I think this change is good. The library story is a bit difficult, but fundamentally openmp needs a shim of some sort to map target math functions onto the libm of the underlying device.

For nvptx, that's the cuda library. Amdgcn has math functions and may need another shim to map them to libm.

include_next is nasty, but that's the existing pattern for some library headers.



================
Comment at: clang/test/Headers/Inputs/include/complex:10
+// Taken from libc++
+template <class _Tp>
+class complex {
----------------
Can we #include from libc++ instead? Needs some cmake to skip the test if the library is unavailable but spares duplicating this class


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80897/new/

https://reviews.llvm.org/D80897