[Openmp-commits] [PATCH] D83077: [OpenMP][Tests] Flag compatibility of OpenMP runtime tests with GCC versions

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim created this revision.
protze.joachim added a reviewer: AndreyChurbanov.
protze.joachim added a project: OpenMP.
Herald added subscribers: sstefan1, guansong, yaxunl.
Herald added a reviewer: jdoerfert.

Some of the recently added tests are not compatible with GCC. Also checked compatibility with GCC 10

If the compilation fails, the test is marked as unsupported.
-> This will never change for a specific version of gcc

If the linking fails, the test is marked as expected to fail.
-> This might change as LLVM/OpenMP implements the missing GOMP interface function

I successfully ran `make check-libomp` with GCC versions 6-10
Issues with the OMPT tests are addressed in D82267 <https://reviews.llvm.org/D82267>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83077

Files:
  openmp/runtime/test/tasking/omp_detach_taskwait.c
  openmp/runtime/test/tasking/omp_task_red_taskloop.c
  openmp/runtime/test/worksharing/for/bug_set_schedule_0.c
  openmp/runtime/test/worksharing/for/omp_for_schedule_runtime.c
  openmp/runtime/test/worksharing/for/omp_nonmonotonic_dynamic1.c


Index: openmp/runtime/test/worksharing/for/omp_nonmonotonic_dynamic1.c
===================================================================
--- openmp/runtime/test/worksharing/for/omp_nonmonotonic_dynamic1.c
+++ openmp/runtime/test/worksharing/for/omp_nonmonotonic_dynamic1.c
@@ -1,6 +1,10 @@
 // RUN: %libomp-compile
 // RUN: env OMP_SCHEDULE=nonmonotonic:dynamic,10 %libomp-run
 
+// gcc 9/10 use GOMP_parallel_loop_maybe_nonmonotonic_runtime, not implemented
+// Should be removed once the functions are implemented
+// XFAIL: gcc-9, gcc-10
+
 // The test checks iterations distribution for OMP 5.0 nonmonotonic OMP_SCHEDULE
 // case #threads > #chunks (fallback to monotonic dynamic)
 
Index: openmp/runtime/test/worksharing/for/omp_for_schedule_runtime.c
===================================================================
--- openmp/runtime/test/worksharing/for/omp_for_schedule_runtime.c
+++ openmp/runtime/test/worksharing/for/omp_for_schedule_runtime.c
@@ -10,6 +10,11 @@
 // RUN: env OMP_SCHEDULE=trapezoidal,13 %libomp-run 101 13
 // RUN: env OMP_SCHEDULE=static_steal %libomp-run 102 1
 // RUN: env OMP_SCHEDULE=static_steal,14 %libomp-run 102 14
+
+// gcc 9/10 use GOMP_parallel_loop_maybe_nonmonotonic_runtime, not implemented
+// Should be removed once the functions are implemented
+// XFAIL: gcc-9, gcc-10
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <math.h>
Index: openmp/runtime/test/worksharing/for/bug_set_schedule_0.c
===================================================================
--- openmp/runtime/test/worksharing/for/bug_set_schedule_0.c
+++ openmp/runtime/test/worksharing/for/bug_set_schedule_0.c
@@ -1,4 +1,9 @@
 // RUN: %libomp-compile-and-run
+
+// gcc 9/10 use GOMP_parallel_loop_maybe_nonmonotonic_runtime, not implemented
+// Should be removed once the functions are implemented
+// XFAIL: gcc-9, gcc-10
+
 #include <stdio.h>
 #include <omp.h>
 #include "omp_testsuite.h"
Index: openmp/runtime/test/tasking/omp_task_red_taskloop.c
===================================================================
--- openmp/runtime/test/tasking/omp_task_red_taskloop.c
+++ openmp/runtime/test/tasking/omp_task_red_taskloop.c
@@ -1,5 +1,12 @@
 // RUN: %libomp-compile-and-run
 
+// Parsing error until gcc8:
+// UNSUPPORTED: gcc-6, gcc-7, gcc-8
+
+// Missing GOMP_taskgroup_reduction_(un)register in LLVM/OpenMP
+// Should be removed once the functions are implemented
+// XFAIL gcc-9, gcc-10
+
 #include <stdio.h>
 #include <omp.h>
 
Index: openmp/runtime/test/tasking/omp_detach_taskwait.c
===================================================================
--- openmp/runtime/test/tasking/omp_detach_taskwait.c
+++ openmp/runtime/test/tasking/omp_detach_taskwait.c
@@ -1,8 +1,8 @@
 // RUN: %libomp-compile -fopenmp-version=50 && env OMP_NUM_THREADS='3' %libomp-run
 // RUN: %libomp-compile -fopenmp-version=50 && env OMP_NUM_THREADS='1' %libomp-run
 
-// Checked gcc 9.2 still does not support detach clause on task construct.
-// UNSUPPORTED: gcc-4, gcc-5, gcc-6, gcc-7, gcc-8, gcc-9
+// Checked gcc 10.1 still does not support detach clause on task construct.
+// UNSUPPORTED: gcc-4, gcc-5, gcc-6, gcc-7, gcc-8, gcc-9, gcc-10
 // clang supports detach clause since version 11.
 // UNSUPPORTED: clang-10, clang-9, clang-8, clang-7
 // icc compiler does not support detach clause.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83077.275203.patch
Type: text/x-patch
Size: 3316 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20200702/f05e0d44/attachment-0001.bin>